zorba-coders team mailing list archive

[Ghislain Fourny <ghislain.fourny@xxxxxxxxxx>]

> - Could the Item::swap function be implemented on JSONObjects, JSONArrays, and
> the base-class for all nodes instead of for Item. It seems like that checking
> if a node is the root and swapping the tree in XmlNode::swap would be
> sufficient. That seems to be more consistent with the way other functions are
> implemented. It also seems to avoid the switch in Item::swap and the
> replication of raising ZSTR0050.

The issue is that access to protected members of Item is needed. They cannot be accessed in XmlNode.
-- 
https://code.launchpad.net/~zorba-coders/zorba/replace-nodes-in-collection/+merge/138196
Your team Zorba Coders is subscribed to branch lp:zorba.