← Back to team overview

zorba-coders team mailing list archive

Thread
Date

Re: lp:~zorba-coders/zorba/sqlite-check-for-metadata-availability into lp:zorba/sqlite-module

To: mp+145041@xxxxxxxxxxxxxxxxxx
From: Chris Hillery <chillery+launchpad@xxxxxxxxx>
Date: Sat, 26 Jan 2013 01:16:20 -0000
In-reply-to: <20130125233619.6277.36966.launchpad@ackee.canonical.com>
Reply-to: mp+145041@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Unless I'm missing something, it'd be cleaner to avoid the compilation of JSONMetadataItemSequence entirely by #ifdef-ing out the class and method definitions in the .cpp and .h files. 
-- 
https://code.launchpad.net/~zorba-coders/zorba/sqlite-check-for-metadata-availability/+merge/145041
Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module.

References

[Merge] lp:~zorba-coders/zorba/sqlite-check-for-metadata-availability into lp:zorba/sqlite-module
From: Luis Rodriguez Gonzalez, 2013-01-25