zorba-coders team mailing list archive

[Chris Hillery <chillery+launchpad@xxxxxxxxx>]

Review: Approve

I do have two minor points, but they're just about comments so I'll go ahead and leave my Approve vote too.

First, one minor typo: "ahe" instead of "the" in regex.cpp.

Second, question about comment:

     //
     // The '=' is neither the first or last character within a
     // character range (i.e., a literal '-') so therefore it's
     // indicating a character range.
     //

Is there some context about '=' that I'm missing, or is that just a typo and it should be '-'?

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.