zorba-coders team mailing list archive

[Chris Hillery <chillery+launchpad@xxxxxxxxx>]

Review: Needs Fixing

I just realized that the set of options for canonicalization (as proposed by Matthias) are overlapping with the options that already exist for XML parsing. But the current implementation adds an entirely new set of options. This looks pretty silly, and is a waste of code.

The options Matthias requested are strictly for parsing the input XML, and as such, x:canonicalize#2 should accept precisely the same <options> element as x:parse#2. I mean, they're two functions in the same module which do the same thing (parse XML); they should take the same options.
-- 
https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394
Your team Zorba Coders is subscribed to branch lp:zorba.