← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/feature-compare_null into lp:zorba

 

Review: Approve

Hi Matthias,

It looks good!

Are you aware that in orderby01.jq, () is converted to a null in the object constructor, so that it is not actually testing how () compares to null with a sort?

Perhaps you can add tests that check that "() eq null" and "null eq ()" return ()?

(It should be the case, I checked on the command line).

-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-compare_null/+merge/157008
Your team Zorba Coders is subscribed to branch lp:zorba.


References