zorba-coders team mailing list archive

Thread
Date

Re: [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba

To: mp+157755@xxxxxxxxxxxxxxxxxx
From: Chris Hillery <chillery+launchpad@xxxxxxxxx>
Date: Mon, 15 Apr 2013 21:40:35 -0000
In-reply-to: <20130408212725.9345.4086.launchpad@ackee.canonical.com>
Reply-to: mp+157755@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

I agree with your logic, Juan; thanks for spelling it out. I hadn't realized that your new flag were not checked in the inner loop of fn:subsequence(), but looking at the implementation it appears that is the case. So I have no problem with it.

Voting Approve now, although clearly the two failing FOTS tests will need to be addressed before it will merge.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch lp:zorba.

References

[Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba
From: Juan Zacarias, 2013-04-08