zorba-coders team mailing list archive

Thread
Date

Re: [Merge] lp:~zorba-coders/zorba/util-jvm-rpath into lp:zorba/util-jvm-module

To: mp+163074@xxxxxxxxxxxxxxxxxx
From: Chris Hillery <chillery+launchpad@xxxxxxxxx>
Date: Thu, 09 May 2013 00:43:22 -0000
In-reply-to: <20130509001122.27171.35874.launchpad@ackee.canonical.com>
Reply-to: mp+163074@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

1. I believe that the correct values for RPATH are directories, not actual .so files, so the value of INSTALL_RPATH_PATHS should omit all the "/libjvm.so" parts.

2. FindJNI.cmake says:

# (To distribute this file outside of CMake, substitute the full
#  License text for the above reference.)

So, we should do that.
-- 
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.

References

[Merge] lp:~zorba-coders/zorba/util-jvm-rpath into lp:zorba/util-jvm-module
From: Juan Zacarias, 2013-05-09