zorba-coders team mailing list archive

[Ghislain Fourny <ghislain.fourny@xxxxxxxxxx>]

Review: Needs Fixing

It looks good on the whole. For convenience, I am pasting the list of the findings I sent to the zorba-dev mailing list, as of revision 11342 of this branch, here:

- The dot context item should be a syntax error in the JSONiq parser, but { "foo" : "bar" } ! . seems to parse fine.
- No error is thrown when beginning a path expression with an axis step in the JSONiq parser, e.g. <a><foo/></a>/(foo) (mind the parentheses, i.e., foo does begin a path expression) should not parse with JSONiq.


- Use of \ or & in literals in the common language (both parsers) does not seem to raise warnings. 
- Use of {} in the common language (both parsers) does not seem to raise warnings.
- Use of true/false/null literals in the common language (JSONiq parser) does not seem to raise warnings.
- Use of () for the empty sequence type syntax in the common language (JSONiq parser) does not seem to raise warnings.
- Use of simplified update syntax (no "json") in the common language (JSONiq parser) does not seem to raise warnings.
- Use of single-quoted literals in the common language (XQuery parser) does not seem to raise warnings.
- Use of unquoted object keys in the common language (JSONiq parser) does not seem to raise warnings.
- Use of a path expression beginning with an axis step in the common language (XQuery parser) seems to raise the wrong warning (is : context item expression, should be : path expression may not begin with an axis step).
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.