← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

 

Review: Needs Fixing

1. Very sorry for the mis-information, but this module should NOT have been moved into the zorba.io namespace. EXpath modules should remain in their expath.org/ns namespace.

2. Remove the "how to build the module" information from the XQDoc; XQDoc should only contain information on *using* the module, not building it. Move this information into a top-level README.txt file in the module.

3. Are there any errors which may be raised by these module functions? If so, are they documented?

4. Why did you change the GEOS_VERSION_PATCH check in geo_functions.cpp ?
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.


Follow ups

References