zorba-coders team mailing list archive

[Chris Hillery <chillery+launchpad@xxxxxxxxx>]

Review: Needs Fixing

In archive_module.cpp:

1. Please don't leave commented-out code. Just delete it; it's in the version history if we ever need to refer back to it. For example, remove these lines:

+    //Item lNameItem = theFactory->createString(lName);
+    //lMemberName = theFactory->createString("name");


2. As discussed, if possible, create single zorba::Items for all the JSON object key strings, eg. "name", "size", etc. Possibly create those in the ArchiveModule constructor. Use those constants when creating JSON objects in EntriesIterator::next(), as well as comparing input values in ArchiveEntry::setValues() (and anywhere else it happens to be appropriate).


Also don't forget to assign a bug to yourself to create a JSON schema for this module, and to go back and update the module and test cases accordingly.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188033/+merge/176523
Your team Zorba Coders is subscribed to branch lp:zorba/archive-module.