zorba-coders team mailing list archive

Thread
Date

Re: [Merge] lp:~zorba-coders/zorba/bug-1188033 into lp:zorba/archive-module

To: mp+176523@xxxxxxxxxxxxxxxxxx
From: Chris Hillery <chillery+launchpad@xxxxxxxxx>
Date: Tue, 30 Jul 2013 00:12:27 -0000
In-reply-to: <20130723213924.2207.30516.launchpad@ackee.canonical.com>
Reply-to: mp+176523@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Global Items code looks good now!

As a general rule, don't put actual function definitions into header files. Certain small methods (accessors, usually) can be inline for efficiency, but anything more significant can cause code bloat and other problems. I moved the ArchiveModule() constructor definition into archive_module.cpp. With that done, everything looks fine.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188033/+merge/176523
Your team Zorba Coders is subscribed to branch lp:zorba/archive-module.

References

[Merge] lp:~zorba-coders/zorba/bug-1188033 into lp:zorba/archive-module
From: Luis Rodriguez Gonzalez, 2013-07-23