← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/bug-1189784 into lp:zorba/sqlite-module

 

Review: Approve

Looks good - nice job!

I made three small changes:

1. Moved a <p/> in the metadata() doc to immediately after the leading sentence of the comment.

2. Moved SqliteModule() constructor definition out-of-line.

3. Per mailing list discussion, marked a number of module functions as nondeterministic rather than sequential (per Matthias).
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489
Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module.


References