zorba-coders team mailing list archive

Thread
Date

Re: [Merge] lp:~zorba-coders/zorba/new-jsoniq-update into lp:zorba

To: mp+185295@xxxxxxxxxxxxxxxxxx
From: Matthias Brantner <matthias.brantner@xxxxxxxxxx>
Date: Fri, 13 Sep 2013 01:15:56 -0000
In-reply-to: <20130912152543.19166.17787.codereview@soybean.canonical.com>
Reply-to: mp+185295@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks great. I'll approve and let you decide on one question:

Is it really necessary to make the expressions in the parsenodes non-const? Couldn't you use a unique pointer or auto_ptr in the parser that is passed
to convert_postfix_to_target_and_selector and only released when the JSON expression is created?
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295
Your team Zorba Coders is subscribed to branch lp:zorba.

References

[Merge] lp:~zorba-coders/zorba/new-jsoniq-update into lp:zorba
From: Zorba Build Bot, 2013-09-12