ac100 team mailing list archive

[Gordan Bobic <gordan@xxxxxxxxxx>]

On Fri, 2 Sep 2011 15:21:14 +0200, Henning Heinold 
<henning@xxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Sep 02, 2011 at 12:11:11PM +0100, Gordan Bobic wrote:
> > It would seem there is a typo in the drivers/crypto/tegra-aes.c
> > file. Building it as a module complains about it being non-GPL
> > licenced. This seems to be related to the MODULE_LICENSE("GPLv2")
> > line. This is a typo. It should be either:
> >
> > MODULE_LICENSE("GPL v2")
> >
> > (with a space) or
> >
> > MODULE_LICENSE("GPL")
> >
> > However, fixing this makes it throw up an undefined variable:
> >
> > ERROR: "tegra_chip_uid" [drivers/crypto/tegra-aes.ko] undefined!
> >
> > I saw in the IRC logs that this was discussed by woglinde and
> > marvin24 back in April. Was there ever a proper fix established? I
> > can see that the tegra_chip_uid is defined in arch/arm/tegra/fuse.c,
> > but it isn't immediately obvious why this wouldn't be available to
> > tegra-aes.ko
> >
> > Gordan
>
> Hi,
>
> I have here locally a patch which fixes completly the build of aes
> and using the latest
> stuff from the nvidia git tree. I have now pushed it to
>
> https://gitorious.org/~woglinde/ac100/woglindes-marvin24s-kernel/commits/chromeos-ac100-2.6.38-aes

Awesome, thanks Henning. I got the patchset that enables AES and it 
didn't work against Marc's kernel tree (tegra-aes.[c|h] issues), 
although it patched cleanly. I got those two files out of your tree and 
rebuilt, and it seems to work now - module loads and the availability is 
exposed in /proc/crypto! :D Going to do some testing with cryptodev 
enabled openssl tonight. :)

Gordan