apport-hackers team mailing list archive
-
apport-hackers team
-
Mailing list archive
-
Message #00139
[Merge] lp:~ev/apport/1205608 into lp:apport
Evan Dandrea has proposed merging lp:~ev/apport/1205608 into lp:apport.
Requested reviews:
Apport upstream developers (apport-hackers)
Related bugs:
Bug #1205608 in apport (Ubuntu): "apport-retrace crashed with AttributeError in join(): 'NoneType' object has no attribute 'endswith'"
https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1205608
For more details, see:
https://code.launchpad.net/~ev/apport/1205608/+merge/177419
Fixes a crash when you specify a sandbox but not a cache.
--
https://code.launchpad.net/~ev/apport/1205608/+merge/177419
Your team Apport upstream developers is requested to review the proposed merge of lp:~ev/apport/1205608 into lp:apport.
=== modified file 'NEWS'
--- NEWS 2013-07-23 04:58:15 +0000
+++ NEWS 2013-07-29 15:47:28 +0000
@@ -13,6 +13,7 @@
together, and give a proper error message in this case. (LP: #1071905)
* apport: Fix "Exectuable" typo, leading to reports not being synced on
upstart crashes. Thanks James Hunt. (LP: #1203744)
+ * apport-retrace: disallow using a sandbox without a cache (LP: #1205608).
2.11 (2013-07-17)
-----------------
=== modified file 'bin/apport-retrace'
--- bin/apport-retrace 2013-01-07 20:39:20 +0000
+++ bin/apport-retrace 2013-07-29 15:47:28 +0000
@@ -72,8 +72,8 @@
# catch invalid usage of -C without -S (cache is only used when making a
# sandbox)
- if opts.cache and not opts.sandbox:
- optparser.error(_('You cannot use -C without -S. Stopping.'))
+ if (opts.cache and not opts.sandbox) or (opts.sandbox and not opts.cache):
+ optparser.error(_('You cannot use -C without -S or vice versa. Stopping.'))
sys.exit(1)
if not (opts.auth or opts.output or opts.stdout or opts.gdb):