apport-hackers team mailing list archive

[Seth Forshee <seth.forshee+lp@xxxxxxxxxxxxx>]

Seth Forshee has proposed merging lp:~sforshee/apport/make-iwl-firmware-dumps-private into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)
Related bugs:
  Bug #1313818 in apport (Ubuntu): "iwlwifi error dumps could contain private information"
  https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1313818

For more details, see:
https://code.launchpad.net/~sforshee/apport/make-iwl-firmware-dumps-private/+merge/217477

Make reports containing iwlwifi firmware dumps private, and subscribe canonical-kernel-team.
-- 
https://code.launchpad.net/~sforshee/apport/make-iwl-firmware-dumps-private/+merge/217477
Your team Apport upstream developers is requested to review the proposed merge of lp:~sforshee/apport/make-iwl-firmware-dumps-private into lp:apport.

=== modified file 'data/iwlwifi_error_dump'
--- data/iwlwifi_error_dump	2014-03-27 08:20:17 +0000
+++ data/iwlwifi_error_dump	2014-04-28 16:53:41 +0000
@@ -46,6 +46,9 @@
 try:
     with open(sysfs_path, 'rb') as f:
         pr['IwlFwDump'] = f.read()
+        # Firmware dump could contain sensitive information
+        pr['LaunchpadPrivate'] = 'yes'
+        pr['LaunchpadSubscribe'] = 'canonical-kernel-team'
 except IOError:
     pass