arsenal-devel team mailing list archive

[Bryce Harrington <bryce@xxxxxxxxxxxxx>]

Looks good brian, pushed to arsenal.  I'll test over the next couple
days for any issues.  Agreed this should speed things up quite nicely.

On Fri, Mar 26, 2010 at 04:33:41PM -0700, Brian Murray wrote:
> I'm headed out for vacation and didn't want to commit this patch
> without testing it, so if someone could test it that'd be great!
> 
> This should be a much faster way of checking if a bug report has a
> patch.  Instead of checking every attachment to see if it is a patch
> we'll just use the latest_patch_uploaded attribute of the bug.
> 
> --
> Brian Murray
> Ubuntu Bug Master
> Days running lucid: 46

> === modified file 'scripts/arsenal_lib.py'
> --- scripts/arsenal_lib.py	2010-03-25 00:28:00 +0000
> +++ scripts/arsenal_lib.py	2010-03-26 23:31:01 +0000
> @@ -171,9 +171,8 @@
>          return False                
>  
>      def has_patch(self):
> -        for a in self.bug.attachments:
> -            if a.type == "Patch":
> -                return True
> +        if self.bug.latest_patch_uploaded:
> +            return True
>          return False
>  
>      # Searches title, description, and comments for given regular expression
> 




> _______________________________________________
> Mailing list: https://launchpad.net/~arsenal-devel
> Post to     : arsenal-devel@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~arsenal-devel
> More help   : https://help.launchpad.net/ListHelp