arsenal-devel team mailing list archive

[Kamran Riaz Khan <krkhan@xxxxxxxxxxxxxx>]

On 07/21/2010 04:35 AM, Bryce Harrington wrote:
> I've posted my proposed filters code to this branch:
> 
>   lp:~bryceharrington/arsenal/lpltk-filtered-attachments
> 
> Note this is totally untested and likely has typos and errors, but
> wanted to get it up for discussion.
> 
> Let me know your thoughts.  I'll plan on landing this in a couple days
> after I've done some testing of it, unless anyone has any qualms that
> should be addressed.

First of all, it's certainly a great idea. Adding filters like this
would make the code simpler.

Onto the proof of concept branch, lpltk's Attachments class has the
additional benefit of using yield generators in order to process large
sets of attachments. IIUC, while your filtered_attachments has the
benefit of providing cleaner interface for filtering it nullifies the
generator benefits by filtering all the attachments at once instead of
relying on yield.

In other words, I think:

    def __iter__(self):
        for attachment in self._attachments:

            # this is a more suitable place for checking
            # attachment and deciding whether or not to yield it
            # based on filters

            yield Attachment(self.__tkbug, attachment)

This way, the generators shall be yielded after checking the attachment
at run-time one-by-one. That is, if there are 100 attachments, instead
of filtering them all first and then returning an iterator this shall
process them one-by-one while yielding Attachment instances.

If no one else takes this up, I'll try uploading a branch with this
implementation after I get done with send_upstream.cgi and
send-attachments-upstream.

Regards,
-- 
Kamran Riaz Khan.

http://inspirated.com/