ayatana-commits team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

On Tue, 2009-11-24 at 11:08 +0000, Mirco Müller wrote:

> Review: Disapprove 

Meta: why? what part of this is so bad that you don't want it fix, but
just want it to go away (thats what disapprove means). The actual body
of your review reads more like 'I may have to merge this carefully and
please explain about Xvfb' which is not really disapproval.

> Not so fast folks... notify-osd trunk is behind notify-osd/karmic at
> the moment.

This makes it very hard to figure out where to do work. I presume there
is a good reason for this. Can we figure out how to avoid that in
future? 

It also implies that the karmic changes didn't get code reviewed, if
reviews are happening only on trunk.

>  I still have/want to get it in line with the karmic-branch before
> branching off for lucid. That work is meant to happen with the
> notify-osd SRU for Karmic. The not-passing tests are fixed in the
> Karmic-branch, which the the branch that saw most of the work.
>
> I'm ok with the support for the "UNATTENDED" env-var. Robert and I
> have chatted about that some time before the Dallas sprint/UDS.
> 
> What's test-support.am doing exactly? In particular how does Xvfb work
> and what are all those XIDs good for? 

Its just machinery to get an X server up and running without linear
probing for available server slots.

-Rob

-- 
https://code.launchpad.net/~lifeless/notify-osd/tests/+merge/15182
Your team ayatana-commits is subscribed to branch lp:notify-osd.