ayatana-commits team mailing list archive

[Mirco Müller <mirco.mueller@xxxxxxxxxxxxx>]

> On Tue, 2009-11-24 at 11:08 +0000, Mirco Müller wrote:
> 
> > Review: Disapprove
> 
> Meta: why? what part of this is so bad that you don't want it fix, but
> just want it to go away (thats what disapprove means). The actual body
> of your review reads more like 'I may have to merge this carefully and
> please explain about Xvfb' which is not really disapproval.

Oh, that should have been "Needs Information".

> > Not so fast folks... notify-osd trunk is behind notify-osd/karmic at
> > the moment.
> 
> This makes it very hard to figure out where to do work. I presume there
> is a good reason for this. Can we figure out how to avoid that in
> future?

Isn't this the normal procedure? Do feature work in trunk during Alpha-period. Once Beta-period starts branch off for bug-fix-only to mature the code-base. After final release merge fixes back to trunk.

That merge back has not happened yet, because jumping on Lucid for helping to work on unity became highest/only priority.

Even now I don't have explicit "green light" for the merge-back yet. But this is meant to come during the week, once I've send David my fixes-list for the notify-osd Karmic-SRU.

> It also implies that the karmic changes didn't get code reviewed, if
> reviews are happening only on trunk.

No. From the branch off for Karmic code-reviews happened on the karmic-branch of notify-osd. So far nobody complained about the way we go about our code-review targets. Well, I also did TDD on notify-osd as good as I could, once it was demanded, which was - according to your remarks from the Montreal-sprint - not reasonable to do as an afterthought.

It looks like there are still differences in the applied "best practices". I'm eager to learn about a better approach, but so far didn't feel I was doing something wrong.

> > What's test-support.am doing exactly? In particular how does Xvfb work
> > and what are all those XIDs good for?
> 
> Its just machinery to get an X server up and running without linear
> probing for available server slots.

Is that something I can easily test locally on my box here? If so I'd like to know how in order to replicate this, just for getting a better understanding what's going on there on the testing-systems.
-- 
https://code.edge.launchpad.net/~lifeless/notify-osd/tests/+merge/15182
Your team ayatana-commits is subscribed to branch lp:notify-osd.