← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~ted/indicator-session/removing-me into lp:indicator-session

 

Review: Needs Fixing
Ok, this is a dynamic account... But that loop means that it's going to be very costly on system connected to directories with thousands of entries.

I think you should exploit that fact that a guest account is a system one, ie with an ID below LAST_SYSTEM_UID. That's in /etc/adduser.conf.

Not sure if that changes a lot, but as 'guest' is already hardcoded, either hardcoding to < 999, or sourcing the conf file to get the environment variable.
-- 
https://code.launchpad.net/~ted/indicator-session/removing-me/+merge/20474
Your team ayatana-commits is subscribed to branch lp:indicator-session.



Follow ups

References