← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~ted/indicator-session/removing-me into lp:indicator-session

 

On Tue, 2010-03-02 at 23:12 +0000, David Barth wrote:
> Ok, this is a dynamic account... But that loop means that 
> it's going to be very costly on system connected to directories 
> with thousands of entries.
> 
> I think you should exploit that fact that a guest account is 
> a system one, ie with an ID below LAST_SYSTEM_UID. That's in 
> /etc/adduser.conf.
> 
> Not sure if that changes a lot, but as 'guest' is already 
> hardcoded, either hardcoding to < 999, or sourcing the conf 
> file to get the environment variable.

But, we're getting all the names from GDM.  I don't think that we can
request a subset of that list.  I think the only way we could do it is
to specially request information on the guest account from ConsoleKit
and avoid GDM all together.

The other option would be to not show if the guest is logged in when
we're in "overflow mode."

I guess my feeling is that we're talking about thousands of string
comparisons.  Which, on a modern processor is calculated in ms...

But, if you want, we can go with option A.  I think it'd be the best,
just talk to ConsoleKit directly about the guest account.

-- 
https://code.launchpad.net/~ted/indicator-session/removing-me/+merge/20474
Your team ayatana-commits is subscribed to branch lp:indicator-session.



References