ayatana-commits team mailing list archive

[Kalle Valo <kalle.valo@xxxxxxxxxxxxx>]

Review: Needs Fixing
Sorry, but I think this is not ready yet. Few comments:

* -Werror removed. I think that's not a good idea.
* Indentation changes make code review difficult.
* Two indentation styles in new code
* A lot of code commented out. Especially I want to emphasise this part:

999	+    // TODO: uncomment for release !!
1000	+   	//close_pulse_activites();
1001	+    //g_main_loop_quit(mainloop);

I didn't take a look at the actual code yet.
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/custom_player_controls/+merge/27612
Your team ayatana-commits is subscribed to branch lp:indicator-sound.