ayatana-commits team mailing list archive

Thread
Date

Re: [Merge] lp:~cjcurran/indicator-sound/custom_player_controls into lp:indicator-sound

To: Conor Curran <conor.curran@xxxxxxxxxxxxx>
From: David Barth <david.barth@xxxxxxxxxxxxx>
Date: Tue, 15 Jun 2010 12:28:25 -0000
In-reply-to: <20100615103539.25936.22219.launchpad@loganberry.canonical.com>
Reply-to: mp+27612@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve
Looks better to me. In the 2 widgets, the _dispose function leaks memory. While I appreciate that it's tedious to maintain that during the UI prototyping phase, at least it'd deserve a big /* TODO */ in those functions to make it obvious there is a huge leak. Otherwise, cool!

+1 with the /* TODO */ lines added.
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/custom_player_controls/+merge/27612
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

References

[Merge] lp:~cjcurran/indicator-sound/custom_player_controls into lp:indicator-sound
From: Conor Curran, 2010-06-15