← Back to team overview

ayatana-commits team mailing list archive

[Merge] lp:~cjcurran/indicator-sound/text-resize-fix into lp:indicator-sound

 

Conor Curran has proposed merging lp:~cjcurran/indicator-sound/text-resize-fix into lp:indicator-sound.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)


text resizing of the track metadata is now done using pixels rather than number of characters. 
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/text-resize-fix/+merge/37490
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
=== modified file 'src/metadata-widget.c'
--- src/metadata-widget.c	2010-10-01 16:51:18 +0000
+++ src/metadata-widget.c	2010-10-04 16:17:59 +0000
@@ -120,8 +120,8 @@
 	                                                      DBUSMENU_METADATA_MENUITEM_ARTIST));
 	gtk_misc_set_alignment(GTK_MISC(artist), (gfloat)0, (gfloat)0);
 	gtk_misc_set_padding (GTK_MISC(artist), (gfloat)10, (gfloat)0);
-	gtk_label_set_width_chars(GTK_LABEL(artist), 15);	
-	gtk_label_set_ellipsize(GTK_LABEL(artist), PANGO_ELLIPSIZE_MIDDLE);	
+  gtk_widget_set_size_request (artist, 140, 15);
+  gtk_label_set_ellipsize(GTK_LABEL(artist), PANGO_ELLIPSIZE_MIDDLE);	
 	metadata_widget_style_labels(self, GTK_LABEL(artist));
 	priv->artist_label = artist;
 	
@@ -131,8 +131,8 @@
 	                                                      DBUSMENU_METADATA_MENUITEM_TITLE) );
 	gtk_misc_set_alignment(GTK_MISC(piece), (gfloat)0, (gfloat)0);
 	gtk_misc_set_padding (GTK_MISC(piece), (gfloat)10, (gfloat)0);
-	gtk_label_set_width_chars(GTK_LABEL(piece), 15);
-	gtk_label_set_ellipsize(GTK_LABEL(piece), PANGO_ELLIPSIZE_MIDDLE);
+  gtk_widget_set_size_request (piece, 140, 15);
+  gtk_label_set_ellipsize(GTK_LABEL(piece), PANGO_ELLIPSIZE_MIDDLE);
 	metadata_widget_style_labels(self, GTK_LABEL(piece));
 	priv->piece_label =  piece;
 
@@ -142,7 +142,7 @@
 	                                                          DBUSMENU_METADATA_MENUITEM_ALBUM) );
 	gtk_misc_set_alignment(GTK_MISC(container), (gfloat)0, (gfloat)0);
 	gtk_misc_set_padding (GTK_MISC(container), (gfloat)10, (gfloat)0);	
-	gtk_label_set_width_chars(GTK_LABEL(container), 15);		
+  gtk_widget_set_size_request (container, 140, 15);
 	gtk_label_set_ellipsize(GTK_LABEL(container), PANGO_ELLIPSIZE_MIDDLE);	
 	metadata_widget_style_labels(self, GTK_LABEL(container));
 	priv->container_label = container;
@@ -505,7 +505,6 @@
 	MetadataWidgetPrivate * priv = METADATA_WIDGET_GET_PRIVATE(widg);	
   priv->theme_change_occured = TRUE;    
 	gtk_widget_queue_draw(GTK_WIDGET(metadata));  
-	//g_debug("metadata_widget: theme change");        
 }
 
 static void


Follow ups