← Back to team overview

ayatana-commits team mailing list archive

Re: lp:~cimi/indicator-messages/fixes-to-right-label-and-icon-dimension into lp:indicator-messages

 

> On Fri, 2010-10-01 at 15:06 +0000, David Barth wrote:
> > +static gchar *
> > +get_current_font_name ()
> > +{
> > +     GtkSettings *settings = gtk_settings_get_default();
> > +     gchar *font_name;
> > +
> > +     g_object_get (settings, "gtk-font-name", &font_name, NULL);
> > +
> > +     return font_name;
> > +}
> > +
> > +static gint
> > +get_current_font_size (gchar *font_name)
> > +{
> > +     gint font_size;
> > +     PangoFontDescription *font_description;
> > +
> > +     font_description = pango_font_description_from_string (font_name);
> > +     font_size = pango_font_description_get_size (font_description);
> > +
> > +     return font_size / PANGO_SCALE;
> > +}
> > +
> 
> I'm curious why you're getting these from the global GTK defaults and
> not from the widget information.  For instance, if the widget style was
> different in the panel it seems like those settings would not get
> inherited.
> 

Updated the branch checking gtksettings on a per-widget basis.
Please review it, it's so late here I might be asleep :)

A different issue is making me crazy: those "blank" labels on the right, just the rounded fill and no text inside. Do you think that something like "if (!layout) return FALSE;" might help in numbers_draw_cb?
-- 
https://code.launchpad.net/~cimi/indicator-messages/fixes-to-right-label-and-icon-dimension/+merge/37272
Your team ayatana-commits is subscribed to branch lp:indicator-messages.



References