ayatana-commits team mailing list archive

[Michael Terry <michael.terry@xxxxxxxxxxxxx>]

Michael Terry has proposed merging lp:~mterry/indicator-application/update-label-too into lp:indicator-application.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  #712581 keyboard layout label is not updated
  https://bugs.launchpad.net/bugs/712581

For more details, see:
https://code.launchpad.net/~mterry/indicator-application/update-label-too/+merge/49403

In debugging bug 712581, I realized why the keyboard layout label was not being updated.  It was because indicator-application was doing an apply_status right before processing the XAyatanaNewLabel signal.  So when it processed the NewLabel signal, it thought it already had the new labels (set during apply_status) and ignored it.

This branch makes it so that when emitting an IconChanged signal as part of apply_status, it also emits a LabelChanged signal.
-- 
https://code.launchpad.net/~mterry/indicator-application/update-label-too/+merge/49403
Your team ayatana-commits is subscribed to branch lp:indicator-application.

=== modified file 'src/application-service-appstore.c'
--- src/application-service-appstore.c	2011-02-07 18:01:11 +0000
+++ src/application-service-appstore.c	2011-02-11 15:11:39 +0000
@@ -845,6 +845,10 @@
 
 			emit_signal (appstore, "ApplicationIconChanged",
 				     g_variant_new ("(is)", position, newicon));
+			emit_signal (appstore, "ApplicationLabelChanged",
+				     g_variant_new ("(iss)", position, 
+		                                    app->label != NULL ? app->label : "",
+		                                    app->guide != NULL ? app->guide : ""));
 		}
 	}