banking-addons-drivers team mailing list archive

[Virgil Dupras <virgil.dupras@xxxxxxxxxxxxxxxxxxxx>]

Hi Joël,

Yes, backward compatibility has to be kept. However, due to the nature 
of the refactoring I'm planning, some features (for example the 
commission computation logic) have to be extracted away. I was thinking 
that it should go in a separate module 
(account_statement_import_commission?), so the backward compatibility 
would be kept only if the user who upgrades installs this new module.

If we want to keep backward compatibility to a level where new module 
installation wouldn't be required, then we would have to create a new 
"base" module for "truly abstract" functionality, from which 
account_statement_base_import would inherit.

Now, this code I've uploaded is preliminary and doesn't really work yet, 
so any review should be one of my intent :) But if we agree on this goal 
I've given myself, then I can continue working towards it and keep you 
updated on my progress.

Regards,
--
Virgil Dupras
Consultant en logiciel libre
Savoir-faire Linux Inc.
418-525-7354 #151

Le 13-05-29 05:12 AM, Joël Grand-Guillaume a écrit :
> Hi Virgil,
>
> It sounds good to me to re-factor this module the way you suggest it.
> Just need to keep backward compatibility here as many projects rely on
> it on our side.
>
> Your contribution is very welcome and we'll help you if needed.
>
> I include Nicolas in copy as he will probably review your work.
>
> Regards,
>
> Joël
>
>
>
>
> On Tue, May 28, 2013 at 8:52 PM, Virgil Dupras
> <virgil.dupras@xxxxxxxxxxxxxxxxxxxx
> <mailto:virgil.dupras@xxxxxxxxxxxxxxxxxxxx>> wrote:
>
>     Hi everyone,
>
>     A while ago, I submitted a blueprint at
>     https://blueprints.launchpad.__net/banking-addons/+spec/__purge-base-import
>     <https://blueprints.launchpad.net/banking-addons/+spec/purge-base-import>
>     in which I suggest a re-factoring of account_statement_base_import.
>     I also started to work on it
>     (lp:~hsoft/banking-addons/__purge-base-import), but I wanted to know
>     if you guys thought it's a good idea before I continue working on it.
>
>     Did you look at it? Could you please let me know what you think?
>
>     Regards,
>     --
>     Virgil Dupras
>     Consultant en logiciel libre
>     Savoir-faire Linux Inc.
>     418-525-7354 #151 <tel:418-525-7354%20%23151>
>
>     --
>     Mailing list: https://launchpad.net/~__banking-addons-drivers
>     <https://launchpad.net/~banking-addons-drivers>
>     Post to     : banking-addons-drivers@lists.__launchpad.net
>     <mailto:banking-addons-drivers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~__banking-addons-drivers
>     <https://launchpad.net/~banking-addons-drivers>
>     More help   : https://help.launchpad.net/__ListHelp
>     <https://help.launchpad.net/ListHelp>
>
>
>
>
> --
>
>
> *camptocamp*
> INNOVATIVE SOLUTIONS
> BY OPEN SOURCE EXPERTS
>
> *Joël Grand-Guillaume*
> Division Manager
> Business Solutions
>
> +41 21 619 10 28
> www.camptocamp.com <http://www.camptocamp.com/>