banking-addons-drivers team mailing list archive

[Alexis de Lattre <alexis@xxxxxxxxxx>]

Le 21/03/2014 17:35, Bidoul, Stéphane a écrit :
> I just did a quick check with and without account_banking_payment.
>
> With standard account_payment, communication2 becomes read-only when 
> state is structured communication, and both communication and 
> communication2 are available when state is free. So that looks fine to 
> me as we want to restrict to one communication line when it is of type 
> structured communication and use both otherwise.

Good spot ! I only tested with account_banking_payment, so I didn't see 
the difference with the regular module account_payment.

> So I don't really understand why account_banking_payment disables 
> communication1 for free communication.
>
> I would remove that behaviour from account_banking_payment.

I propose the following :
- Structured => 'communication'
- Free => 'communication' + 'communication2'

Note that, when using SEPA with Free communication, only the 
'communication' field is taken into account to generate the SEPA XML file.

Here is the MP :

https://code.launchpad.net/~akretion-team/banking-addons/70-communication-communication2-clarify/+merge/212271

The most important thing in this MP is that, if you want a different 
behavior, it will now be super-easy to implement because I have added a 
_prepare function in the "Select Invoices to Pay" wizard !

For those like me who think that the 'communication2' field is against 
usability, they can use my module "account_payment_hide_communication2" 
in the branch lp:~akretion-team/+junk/70-usability

Have a nice week-end,

--
Alexis de Lattre