banking-addons-drivers team mailing list archive

[Stefan Rijnhart <stefan@xxxxxxxx>]

On 03/22/2014 02:06 AM, Alexis de Lattre wrote:
> Le 21/03/2014 17:35, Bidoul, Stéphane a écrit :
>> I just did a quick check with and without account_banking_payment.
>>
>> With standard account_payment, communication2 becomes read-only when
>> state is structured communication, and both communication and
>> communication2 are available when state is free. So that looks fine
>> to me as we want to restrict to one communication line when it is of
>> type structured communication and use both otherwise.
>
> Good spot ! I only tested with account_banking_payment, so I didn't
> see the difference with the regular module account_payment.

The banking-addons don't seem to change anything in the interface, but
they do change the semantics of the fields so that 'communication2' is
used for unstructured communication and 'communcation' is used for
structured.

Coded before my time but it seems that the legacy format for payment
exports in the Netherlands allowed for both a structured and an
unstructured communication (unlike SEPA!). That could explain this
design choice.

I'm not against changing this, but it does mean that this semantics need
to be changed in the override of payment.order.create, and in the legacy
Clieop3 export module (still usable in the Netherlands I'm afraid). We
also need a small migration script for existing payment orders in
draft/confirmed state.

Cheers,
Stefan


-- 
Therp - Maatwerk in open ontwikkeling

Stefan Rijnhart - Ontwerp en implementatie

mail: stefan@xxxxxxxx
tel: +31 (0) 614478606
http://therp.nl
https://twitter.com/therp_stefan