← Back to team overview

banking-addons-drivers team mailing list archive

Re: banking refactoring next step

 

My comments inline:

2014-09-17 17:38 GMT+02:00 Bidoul, Stéphane <stephane.bidoul@xxxxxxxxx>:

> Hi,
>
> This work I'm doing now, plus the work Alexis is doing in backporting the
> bank statement import framework from Odoo master, makes me think it's time
> to attempt to clarify OCA banking landscape.
>
> Some questions - these are a bit bold, not intended to offense anyone,
> only to trigger the discussion:
> - should we deprecate OCA/account-payment in favor of the payment part of
> OCA/banking:
>

I'm pushing spanish community in 8.0 to use banking-payment instead of
account-payment, to unify efforts in SEPA area and so on. There is only one
module that deserves to be rescued: paydays, that allows to set more than
one payment day, and also modifies current behaviour for only one payment
day: if payment day is greater than current month day, payment term is set
that day on this month, not on the next one.

- should we merge OCA/bank-statement-reconcile and the bank statement
> import part of OCA/banking (we already said yes, but can we do it now?)
>

I think so.


> - should we deprecate the bank statement import features we have in OCA in
> favor of a backport of the new framework in Odoo master branch?
>

We should use this core framework for 8.0, but not backporting it to 7.0,
6.1.


>
> Is it the right time for such decisions? How to organize the discussion?
>

Of course it is. We say when 8.0 arrives, and this is now ;)

>
> Best regards,
>

Regards.

>
> -sbi
>
> On Wed, Sep 17, 2014 at 1:05 PM, Bidoul, Stéphane <
> stephane.bidoul@xxxxxxxxx> wrote:
>
>> Thanks for the feedback. I'm working on it.
>>
>> This is looking quite elegant so far, with the payment order status
>> moving to done based on the reconciliation status of the transfer moves and
>> workflow triggers. While I'm at it, I'm also adapting Stefan's test suite.
>>
>> I'll soon push a branch on top of Pedro's 8.0 port so we have a concrete
>> basis to discuss the next steps.
>>
>> Cheers,
>>
>> -sbi
>>
>> On Tue, Sep 16, 2014 at 9:28 AM, Joël Grand-Guillaume <
>> joel.grandguillaume@xxxxxxxxxxxxxx> wrote:
>>
>>> +1 as well !
>>>
>>> On Mon, Sep 15, 2014 at 8:35 AM, Frédéric Clementi <
>>> frederic.clementi@xxxxxxxxxxxxxx> wrote:
>>>
>>>> It definitely makes sense, Stephane
>>>> +1
>>>>
>>>> Cordialement,
>>>>
>>>> *camptocamp*
>>>>
>>>> INNOVATIVE SOLUTIONS
>>>> BY OPEN SOURCE EXPERTS
>>>>
>>>> *Frédéric Clementi*
>>>> Project Manager
>>>> Business Solutions
>>>>
>>>> +41 21 619 10 41
>>>>
>>>> www.camptocamp.com
>>>>
>>>>
>>>> 2014-09-14 20:12 GMT+02:00 Stefan <stefan@xxxxxxxx>:
>>>>
>>>>> On 12-09-14 18:36, Bidoul, Stéphane wrote:
>>>>> > Hi banking addons drivers,
>>>>> >
>>>>> > In my quest to de-entangle the statement import and payment features
>>>>> > of the banking addons. I'm considering to do a next refactoring step.
>>>>> >
>>>>> > Namely, what I plan to do is extract from account_banking_payment the
>>>>> > feature that reconciles the invoice by creating a move to a transfer
>>>>> > account when the payment order is sent.
>>>>> >
>>>>> > I have the feeling this feature can live in a rather standalone
>>>>> module.
>>>>> >
>>>>> > Does that make sense to you? Any thoughts?
>>>>> >
>>>>>
>>>>> That would be good. Try and integrate the payment order workflow
>>>>> (between send and done states) with the move line model instead of
>>>>> triggering this explicitely from the bank order line
>>>>> confirmation/cancelling as it is now: payment order (line) status would
>>>>> be to changed upon (un)reconciliation of the move line on the transfer
>>>>> account. This came up a long time ago on this mailing list I believe.
>>>>>
>>>>> Regards,
>>>>> Stefan.
>>>>>
>>>>> --
>>>>> Therp - Maatwerk in open ontwikkeling
>>>>>
>>>>> Stefan Rijnhart - Ontwerp en implementatie
>>>>>
>>>>> mail: stefan@xxxxxxxx
>>>>> tel: +31 (0) 614478606
>>>>> web: http://therp.nl
>>>>>
>>>>>
>>>>> --
>>>>> Mailing list: https://launchpad.net/~banking-addons-drivers
>>>>> Post to     : banking-addons-drivers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~banking-addons-drivers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>
>>>>
>>>> --
>>>> Mailing list: https://launchpad.net/~banking-addons-drivers
>>>> Post to     : banking-addons-drivers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~banking-addons-drivers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>>
>>>
>>> --
>>>
>>>
>>> *camptocamp*
>>> INNOVATIVE SOLUTIONS
>>> BY OPEN SOURCE EXPERTS
>>>
>>> *Joël Grand-Guillaume*
>>> Division Manager
>>> Business Solutions
>>>
>>> +41 21 619 10 28
>>> www.camptocamp.com
>>>
>>>
>>>
>>> --
>>> Mailing list: https://launchpad.net/~banking-addons-drivers
>>> Post to     : banking-addons-drivers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~banking-addons-drivers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>
> --
> Mailing list: https://launchpad.net/~banking-addons-drivers
> Post to     : banking-addons-drivers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~banking-addons-drivers
> More help   : https://help.launchpad.net/ListHelp
>
>

References