banking-addons-team team mailing list archive

[Stefan Rijnhart <stefan@xxxxxxxx>]

On 03/08/2012 01:59 PM, Stefan Rijnhart wrote:
> On 03/08/2012 01:22 PM, James Jesudason wrote:
>
> > The upgrade has focused on the functionality that I'm familiar with 
> > and can test. Since the module handles a lot more scenarios than we 
> > use, I cannot test all of them. So, I think it is better if I could 
> > ask others to start testing this branch and whether we could move to 
> > a new phase of the upgrade.
>
> Thank you for the clear summary. Can you give me a couple of days to 
> do some testing myself?


Well, that took me a whole time more than I anticipated. Apologies for that.

I uploaded a branch with a number of modifications that I would like to 
include in 6.1-dev. Please have a look.

    
https://code.launchpad.net/~therp-nl/banking-addons/6.1-dev-fixes_from_testing_iteration_1/+merge/102061

Apart from that, I looked at your work on delegating the reconcilation, 
rounding and currency conversion to account.voucher and I really like 
it. Thanks again for bringing this up and working on the implementation.

There is still some work needed in this part of the code, because it 
currently does not take match_type into account. The original code 
delegated the creation of the reconciliation to 
import_transaction_obj.confirm(), which in turn applied various methods 
for this depending on the match_type. I think the new code should aim at 
a similar strategy, but to create a voucher instead of a reconciliation 
object. I hope to find a little time for this in the coming weeks.

One thing that I regret a little is that an voucher in OpenERP, when 
canceled deletes all of its move lines but it also explicitely deletes 
all of its reconciliations (see [1]). When an invoice is matched with 
multiple partial payments and one of the statement lines constituting 
these payments is canceled the other statement lines remain confirmed  
and the other payments remain in the system but are now not reconciled 
with the invoice anymore. Previously, the banking addons took care to 
only remove certain move lines from reconciliations and then clean up 
reconciliations with less than two move lines on them. I do not consider 
amending this default behaviour in OpenERP to be within the scope of 
this upgrade effort, however.

Cheers,
Stefan.

[1] 
http://bazaar.launchpad.net/~openerp/openobject-addons/6.1/view/head:/account_voucher/account_voucher.py#L783

--
Therp - Maatwerk in open ontwikkeling

Stefan Rijnhart - Ontwerp en implementatie

mail: stefan@xxxxxxxx
tel: +31 (0) 614478606
http://therp.nl
https://twitter.com/therp_stefan