banking-addons-team team mailing list archive

["Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>]

Review: Approve

just a few small things, approving anyways:

#102 maybe use the opportunity to make this function contaxt-aware?
#140ff same with passing context in the onchange_functions
#550 570, 880 considering how often you use this selection, you should move it to its own field. This also simplifies adjusting the selection
#1591 check if there are line_ids
#1682 should be translated
#1692 too
#1784 why can we drop this check? shouldn't it be changed to check for transit_move_line_id?

Could you elaborate on the sent_wait state? If it's meant how I think it is, such a migration seems not necessary to me. 
-- 
https://code.launchpad.net/~therp-nl/banking-addons/ba7.0-MIG-payment/+merge/166451
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/banking-addons-70.