← Back to team overview

banking-addons-team team mailing list archive

Re: [Merge] lp:~camptocamp/banking-addons/invoice_force_ref into lp:banking-addons/bank-statement-reconcile-70

 

Review: Needs Fixing

"if inv.partner_bank_id.state != 'bvr':"
Seems closely related to the swiss localization, this should be part of a module of this latter.


I disagree with this module being a dependency (or auto-install) of account_advanced_reconcile:
account_advanced_reconcile include few rules and can be extended to add new rules to match the move lines to reconcile. If one or some rules requires the invoice's reference in the line, that's not necessary the case of all of them, and if someone want to totally custom rules, he should not be forced to install this new module and have the reference copied.
-- 
https://code.launchpad.net/~camptocamp/banking-addons/invoice_force_ref/+merge/170542
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-70.


References