← Back to team overview

banking-addons-team team mailing list archive

Re: lp:~camptocamp/banking-addons/bank-statement-reconcile-70-fix-1194881 into lp:banking-addons/bank-statement-reconcile-70

 

Review: Needs Fixing code review, no test

Couldn't you just use inv.partner_id.commercial_partner_id?
Anyway invoice.commercial_partner_id is a related to invoice.partner_id.commercial_partner_id

Your fix implies that if you don't install 'account_report_company', it will use the partner of the invoice, which can be a contact. I think that's wrong, you should probably in all cases use invoice.partner_id.commercial_partner_id.


-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-70-fix-1194881/+merge/171560
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-70.


References