banking-addons-team team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

> I also reach the conclusion that AccountStatementLine can be moved from
> account_statement_base_import to account_statement_base_completion, but this
> should be confirmed by someone more familiar with the project.> 

Agree with that.

Seems good to me (with tests, yeah), some little things:

l.65 
I would replace 
    if st_line['partner_acc_number'] == False:
by 
    if not st_line['partner_acc_number']:

l.96 s/Nomal/Normal/

l.137 empty line before the docstring to remove

l.175 it would probably be useful for the user to give the account number in the error message

l.196ff s/Additionnal/Additional/

Thanks!
-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70/+merge/185047
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70 into lp:banking-addons/bank-statement-reconcile-7.0.