← Back to team overview

banking-addons-team team mailing list archive

Re: lp:~acsone-openerp/banking-addons/ba-70-payment-export-refactoring into lp:banking-addons

 

Review: Resubmit

Hi again, 

Here is a new version.

I adressed all of Stefan's comments:
- module name
- base_iban dependency
- migration of manual_bank_transfer xml id
- the trick/hack/thing about making line2bank receive the payment mode :)

@Stefan, have you ever attempted to integrate that last one in a MP to the core? 
The fix there would be simple, although difficult to explain in a bug report.

plus:
- a bit of pep8
- a view bug I discovered while testing




-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/ba-70-payment-export-refactoring/+merge/179543
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.


References