banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/banking-addons/7.0-abnamro-sepa_type_case into lp:banking-addons.

Requested reviews:
  Banking Addons Core Editors (banking-addons-team)

For more details, see:
https://code.launchpad.net/~therp-nl/banking-addons/7.0-abnamro-sepa_type_case/+merge/188782

This proposal, upon approval, should preferably be merged with 6.1 too by means of cherrypicking

    bzr branch lp:banking-addons/6.1 ba61
    cd ba61
    bzr merge lp:~therp-nl/banking-addons/7.0-abnamro-sepa_type_case -r 189..190

-- 
https://code.launchpad.net/~therp-nl/banking-addons/7.0-abnamro-sepa_type_case/+merge/188782
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~therp-nl/banking-addons/7.0-abnamro-sepa_type_case into lp:banking-addons.

=== modified file 'account_banking_nl_abnamro/abnamro.py'
--- account_banking_nl_abnamro/abnamro.py	2013-06-04 14:56:36 +0000
+++ account_banking_nl_abnamro/abnamro.py	2013-10-02 09:00:52 +0000
@@ -2,7 +2,7 @@
 ##############################################################################
 #
 #    Copyright (C) 2009 EduSense BV (<http://www.edusense.nl>)
-#                  2011 Therp BV (<http://therp.nl>)
+#                  2011 - 2013 Therp BV (<http://therp.nl>)
 #
 #    All Rights Reserved
 #
@@ -256,9 +256,9 @@
 
         if self.transfer_type == 'SEPA':
             sepa_dict = get_sepa_dict(''.join(fields))
-            sepa_type = sepa_dict.get('TRTP')
-            if sepa_type != 'SEPA OVERBOEKING':
-                raise ValueError,_('Sepa transaction type %s not handled yet')
+            sepa_type = sepa_dict.get('TRTP') or ''
+            if sepa_type.upper() != 'SEPA OVERBOEKING':
+                raise ValueError, _('Sepa transaction type %s not handled yet') % sepa_type
             self.remote_account = sepa_dict.get('IBAN',False)
             self.remote_bank_bic = sepa_dict.get('BIC', False)
             self.remote_owner = sepa_dict.get('NAME', False)