banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~therp-nl/banking-addons/7.0-abnamro-sepa_type_case into lp:banking-addons

To: mp+188782@xxxxxxxxxxxxxxxxxx
From: Stéphane Bidoul (Acsone) <stephane.bidoul@xxxxxxxxx>
Date: Wed, 02 Oct 2013 16:55:12 -0000
In-reply-to: <20131002090127.29852.74098.launchpad@ackee.canonical.com>
Reply-to: mp+188782@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review, no test

LGTM. 

BTW, which one is better?

sepa_type = sepa_dict.get('TRTP') or ''
sepa_type = sepa_dict.get('TRTP', '')

-sbi
-- 
https://code.launchpad.net/~therp-nl/banking-addons/7.0-abnamro-sepa_type_case/+merge/188782
Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~therp-nl/banking-addons/7.0-abnamro-sepa_type_case into lp:banking-addons.

References

[Merge] lp:~therp-nl/banking-addons/7.0-abnamro-sepa_type_case into lp:banking-addons
From: Stefan Rijnhart (Therp), 2013-10-02