banking-addons-team team mailing list archive

Thread
Date

Re: lp:~akretion-team/banking-addons/account_statement_base_import_conversion_dict into lp:banking-addons/bank-statement-reconcile-7.0

To: mp+198235@xxxxxxxxxxxxxxxxxx
From: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
Date: Wed, 11 Dec 2013 14:25:45 -0000
In-reply-to: <20131209120125.14612.42718.launchpad@ackee.canonical.com>
Reply-to: mp+198235@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no tests

Hi,

Thanks for the contribs !

 * Line 57 miss spaces after comma (PEP8)

Otherwise, I would like to have Virgil Dupras and Guewen opinions on that one, I'm a bit affraid that we might break some code by changing the keyword argument from extra_field to conversion_dict.

For that main reason I set as need information.
-- 
https://code.launchpad.net/~akretion-team/banking-addons/account_statement_base_import_conversion_dict/+merge/198235
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

References

lp:~akretion-team/banking-addons/account_statement_base_import_conversion_dict into lp:banking-addons/bank-statement-reconcile-7.0
From: Florian da Costa, 2013-12-09