banking-addons-team team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no tests

Hi,

Thanks for the contribs ! 

 * Above Line  41: please adapt the comment if you remove this behavior. The docstring says:
        """
        Hook to build the values of a line from the parser returned values. At
        least it fullfill the statement_id and account_id. Overide it to add your
        own completion if needed.

        :param dict of vals from parser for account.bank.statement.line (called by
                parser.get_st_line_vals)
        :param int/long account_payable: ID of the receivable account to use
        :param int/long account_receivable: ID of the payable account to use
        :param int/long statement_id: ID of the concerned account.bank.statement
        :return: dict of vals that will be passed to create method of statement line.


=> We don't complete account_id anymore in that case right ?

Otherwise good !
-- 
https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-70-account-not-mandatory/+merge/197755
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.