banking-addons-team team mailing list archive

Thread
Date

Re: lp:~akretion-team/banking-addons/bank-statement-reconcile-7.0-add-completion-label into lp:banking-addons/bank-statement-reconcile-7.0

To: Sébastien BEAU - http://www.akretion.com <sebastien.beau@xxxxxxxxxxxx>
From: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
Date: Fri, 13 Dec 2013 12:02:07 -0000
In-reply-to: <20131204172505.32517.22592.launchpad@ackee.canonical.com>
Reply-to: mp+197758@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review, no tests

Hi,

Thanks for the corrections. 2 Littles stuffs I saw now:

 * Line 28-29: use from . import XYZ
 * init_xml is deprecated, you can remove it as well

I still approve this MP as they are minor things, but would appreciate if you could correct them.

Regards,
-- 
https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-7.0-add-completion-label/+merge/197758
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.