banking-addons-team team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Guewen Baconnier @ Camptocamp has proposed merging lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-complete-line-with-commercial-partner-1270135 into lp:banking-addons/bank-statement-reconcile-7.0.

Commit message:
[FIX] Only commercial partners are allowed in bank statement lines

Requested reviews:
  Leonardo Pistone @ camptocamp (lpistone): code review
  Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c): code review, no tests
Related bugs:
  Bug #1270135 in Banking Addons: "[bank-statement-reconcile-7.0] Bank statement reconciliation should autocomplete with "commercial" partner entity only"
  https://bugs.launchpad.net/banking-addons/+bug/1270135

For more details, see:
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0-complete-line-with-commercial-partner-1270135/+merge/202097

Fixes lp:1270135

The statement lines must be only commercial partners, otherwise the move lines are created with the wrong entity.
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0-complete-line-with-commercial-partner-1270135/+merge/202097
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

=== modified file 'account_statement_ext/statement.py'
--- account_statement_ext/statement.py	2014-01-17 13:22:47 +0000
+++ account_statement_ext/statement.py	2014-01-17 13:23:51 +0000
@@ -655,6 +655,8 @@
         # This can be quite a performance killer as we read ir.properity fields
         if partner_id:
             part = obj_partner.browse(cr, uid, partner_id, context=context)
+            part = part.commercial_partner_id
+            res['partner_id'] = part.id
             pay_account = part.property_account_payable.id
             receiv_account = part.property_account_receivable.id
         # If no value, look on the default company property