banking-addons-team team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

> Thanks Guewen, I am not sure I got it right.
> 
> in this diff you are adding to the result the new key partner_id.
> 
> However, in the method onchange_type, it seems like the new returned
> partner_id is ignored. Am I missing something?
> 
> thanks!

Thanks for your feedback.

This is mainly for the other places where get_values_for_line() is called:
account_statement_transactionid_completion/statement.py
account_statement_bankaccount_completion/statement.py
account_statement_base_completion/statement.py
account_statement_so_completion/statement.py

It seems to me that the partner_id argument in the on_change is forcefully already a commercial_partner_id, as there is a domain on the field, so the partner_id will never be wrong and should never be changed by get_values_for_line(). Do you think I should add it for clarity?
-- 
https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0-complete-line-with-commercial-partner-1270135/+merge/202097
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.