banking-addons-team team mailing list archive

Thread
Date

Re: lp:~akretion-team/banking-addons/bank-statement-reconcile-70-account-easy-reconcile-add-commit into lp:banking-addons/bank-statement-reconcile-7.0

To: Sébastien BEAU - http://www.akretion.com <sebastien.beau@xxxxxxxxxxxx>
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Fri, 17 Jan 2014 19:58:10 -0000
In-reply-to: <20131204171626.32518.52460.launchpad@ackee.canonical.com>
Reply-to: mp+197756@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove

I also don't think the correct approach is to commit after every reconcile, because maybe you'll get side effects getting data in a middle stage (for example, start and end balance already imported but not correct, or the reverse).

It's better to improve output error to know exactly what has been wrong, and if you can't correct the error, split the statement until you cut off the conflictive line.

Regards.
-- 
https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-70-account-easy-reconcile-add-commit/+merge/197756
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.