banking-addons-team team mailing list archive

["Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>]

> Hi, Laurent,
> 
> Checking pending MPs, I have found that there is already an MP that issues
> this problem in a similar way:
> 
> https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-
> reconcile-70-improve-import/+merge/197759
> 
> So I'm going to put this as rejected and let the other MP continues. Please
> review it to contribute with your comments.
> 
> Regards.

Hi,

Thanks for the review and the link to the other proposal. I'm a little bit disappointed by your decision. I've the feeling that the proposed approach is more generic that the one proposed by akretion-team.

In the other proposal, it's not the responsibility of the parser to provide additional values to the statement creation. So if I want to provide an other value from the parser to statement (ex the date), I need to override the statement profile. My point of view is that's the responsibility of the parser to provide values for statement and statement line creation. The profile is just there to make the glue between the parser and the logic. What do you think?

Regards

lmi
-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70-import-statement-hook/+merge/201732
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.