banking-addons-team team mailing list archive

["Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>]

Hi,

The proposal covers an identical need that the one I've proposed. I'm not comfortable with your approach. Values available from the parser for the statement are 'hard coded' in the parser and the profile call one by one each method defined on the parser to fill the dictionary used for the statement creation. I've the feeling that it's the responsibility of the parser to fill this dictionary. The profile is just there to do the glue between the parser and the importation logic. 
With your proposal, if I have a parser able to provide more info than the four now available via the new API, I need to override the parser AND the profile.
What do you think of my proposal? https://code.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70-import-statement-hook/+merge/201732

Regards,

lmi


-- 
https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-70-improve-import/+merge/197759
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.