banking-addons-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Fixing

Hi Ruchir,

thanks for the changes. Can you have another look for the following:

- l.219: would be clearer if 'account_obj' was replaced by st_line (or st_line_obj if you wish)\
- l.232: another instance of account_pool -> st_line_pool
- ll.81,251: specifying view type is deprecated in OpenERP 7.0
- l.87: as with your other proposal, it seems to me that the button should be invisible if there is any match type at all.

-- 
https://code.launchpad.net/~ruchir.shukla/banking-addons/banking-addons-change-account_bank_transaction_line/+merge/202409
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons.