banking-addons-team team mailing list archive

Thread
Date

Re: [Merge] lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-import-statement-hook into lp:banking-addons/bank-statement-reconcile-7.0

To: "Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Fri, 31 Jan 2014 22:06:14 -0000
In-reply-to: <20140131102531.31615.45551.launchpad@ackee.canonical.com>
Reply-to: mp+203127@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Now I see redundant to add two methods for the same purpose: get_st_vals and prepare_statement_vals. Do you agree to merge both on one? If you do, I will make inmediately an exceptional merge to fix the mess I did merging the other one without consensus.

Regards.
-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70-import-statement-hook/+merge/203127
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.

Follow ups

Re: [Merge] lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-import-statement-hook into lp:banking-addons/bank-statement-reconcile-7.0
From: Laurent Mignon (Acsone), 2014-02-01

References

[Merge] lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-import-statement-hook into lp:banking-addons/bank-statement-reconcile-7.0
From: Laurent Mignon (Acsone), 2014-01-31