banking-addons-team team mailing list archive

["Laurent Mignon \(Acsone\)" <laurent.mignon@xxxxxxxxx>]

Hi Pedro and once again thanks for the review.
> Now I see redundant to add two methods for the same purpose: get_st_vals and
> prepare_statement_vals. Do you agree to merge both on one? 
The change mirrors the approach for statement lines with the same approach for the statement.
* on the parser we have 'get_st_line_vals' vs 'get_st_vals'
* on the account.statement.profile we have 'prepare_statetement_lines_vals' vs 'prepare_statement_vals'
The motivation behind the 'prepare_statement_vals' is to make a place where it's possible to complete/validate data from the parser in the context of Openerp without overriding the 'statement_import' method. Take a look at the profile developed to import statement files specific to Belgium http://bazaar.launchpad.net/~acsone-openerp/+junk/coda-completion/view/head:/account_statement_coda_import/statement.py#L84 . I think it's a good illustration of the motivation behind the 'prepare_statement_val'. What do you think?

Regards,

Laurent Mignon

-- 
https://code.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70-import-statement-hook/+merge/203127
Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0.